Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(advancer): add rollupsmachine package #520

Merged
merged 3 commits into from
Aug 23, 2024
Merged

feat(advancer): add rollupsmachine package #520

merged 3 commits into from
Aug 23, 2024

Conversation

renan061
Copy link
Contributor

No description provided.

@renan061 renan061 added the #feat:machine-advancer Feature: machine advancer label Jul 16, 2024
@renan061 renan061 added this to the 2.0.0 milestone Jul 16, 2024
@renan061 renan061 self-assigned this Jul 16, 2024
@renan061 renan061 changed the title Feature/rollups machine feat: add rollupsmachine package Jul 16, 2024
@renan061 renan061 changed the base branch from feature/tooling-snapshots to next/2.0 July 16, 2024 04:51
@renan061 renan061 changed the base branch from next/2.0 to feature/tooling-snapshots July 16, 2024 04:51
@renan061 renan061 force-pushed the feature/tooling-snapshots branch from 812ad4c to df3d6c6 Compare July 16, 2024 16:46
@renan061 renan061 force-pushed the feature/rollups-machine branch 2 times, most recently from d9e81fd to 563467b Compare July 16, 2024 17:06
@renan061 renan061 force-pushed the feature/tooling-snapshots branch from df3d6c6 to 370cb46 Compare July 19, 2024 16:33
@renan061 renan061 force-pushed the feature/rollups-machine branch 3 times, most recently from e55b146 to f749688 Compare July 19, 2024 16:59
GMKrieger
GMKrieger reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@GMKrieger GMKrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments

pkg/rollupsmachine/io.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/machine.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/machine_test.go Outdated Show resolved Hide resolved
fmoura
fmoura suggested changes Jul 23, 2024
View reviewed changes
pkg/rollupsmachine/machine.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/error.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/error.go Outdated Show resolved Hide resolved
fmoura
fmoura reviewed Jul 23, 2024
View reviewed changes
pkg/rollupsmachine/io.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/io.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/io.go Outdated Show resolved Hide resolved
fmoura
fmoura suggested changes Jul 24, 2024
View reviewed changes
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
marcelstanley
marcelstanley reviewed Jul 31, 2024
View reviewed changes
pkg/rollupsmachine/machine.go Show resolved Hide resolved
pkg/rollupsmachine/machine.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/machine.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/io.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/machine.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/machine_test.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/error.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/machine.go Outdated Show resolved Hide resolved
pkg/rollupsmachine/server.go Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the feature/tooling-snapshots branch 2 times, most recently from 61a4044 to cbedaf4 Compare August 8, 2024 15:23
@renan061 renan061 force-pushed the feature/rollups-machine branch 2 times, most recently from 6cbd20f to fd6de5e Compare August 8, 2024 15:31
@renan061 renan061 marked this pull request as draft August 9, 2024 18:37
@renan061 renan061 force-pushed the feature/rollups-machine branch 7 times, most recently from d31ee75 to 3e1edf8 Compare August 14, 2024 19:53
@renan061 renan061 force-pushed the feature/rollups-machine branch from 3e1edf8 to 45ecbc9 Compare August 14, 2024 20:56
@renan061 renan061 marked this pull request as ready for review August 14, 2024 20:56
@renan061 renan061 force-pushed the feature/rollups-machine branch 2 times, most recently from e001f5a to 50fadc2 Compare August 14, 2024 21:11
@renan061
Copy link
Contributor Author

renan061 commented Aug 14, 2024 •
edited
Loading

Added unit tests and revised the code.

@renan061 renan061 force-pushed the feature/tooling-snapshots branch from cbedaf4 to 04ffa77 Compare August 15, 2024 17:06
@renan061 renan061 force-pushed the feature/rollups-machine branch from 50fadc2 to 76458a2 Compare August 15, 2024 17:12
@renan061 renan061 linked an issue Aug 19, 2024 that may be closed by this pull request
Add rollupsmachine module #346
Open
4 tasks
@renan061 renan061 changed the title feat: add rollupsmachine package feat(advancer): add rollupsmachine package Aug 22, 2024
fmoura
fmoura reviewed Aug 22, 2024
View reviewed changes
build/docker-bake.hcl Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the feature/rollups-machine branch 2 times, most recently from 715eda7 to 468d9cd Compare August 22, 2024 14:46
GMKrieger
GMKrieger previously approved these changes Aug 22, 2024
View reviewed changes
vfusco
vfusco previously approved these changes Aug 23, 2024
View reviewed changes
@renan061 renan061 force-pushed the feature/tooling-snapshots branch from 04ffa77 to 23cf3d6 Compare August 23, 2024 20:11
Base automatically changed from feature/tooling-snapshots to next/2.0 August 23, 2024 20:19
@renan061 renan061 dismissed stale reviews from vfusco and GMKrieger August 23, 2024 20:19

The base branch was changed.

@renan061 renan061 force-pushed the feature/rollups-machine branch from 468d9cd to 87a24ee Compare August 23, 2024 20:22
@renan061 renan061 merged commit 87a24ee into next/2.0 Aug 23, 2024
6 checks passed
@renan061 renan061 deleted the feature/rollups-machine branch August 23, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelstanley marcelstanley marcelstanley approved these changes

@fmoura fmoura fmoura approved these changes

@GMKrieger GMKrieger GMKrieger left review comments

@vfusco vfusco vfusco left review comments

Assignees

@renan061 renan061

Labels
#feat:machine-advancer Feature: machine advancer
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Add rollupsmachine module
5 participants
@renan061 @fmoura @vfusco @marcelstanley @GMKrieger