Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(advancer): add tooling for creating snapshots programmatically #498

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat(advancer): add tooling for creating snapshots programmatically #498

merged 1 commit into from
Aug 23, 2024

Conversation

renan061
Copy link
Contributor

@renan061 renan061 commented Jul 1, 2024

No description provided.

@renan061 renan061 self-assigned this Jul 1, 2024
@renan061 renan061 changed the base branch from main to feature/emulator-bindings July 1, 2024 21:33
@renan061 renan061 changed the title Feature/tooling snapshots feat: add tooling for creating snapshots programmatically Jul 1, 2024
@renan061 renan061 added #feat:tests Feature: tests #feat:ci Feature: continuous integration #feat:machine-advancer Feature: machine advancer labels Jul 1, 2024
@renan061 renan061 added this to the 2.0.0 milestone Jul 1, 2024
@renan061 renan061 mentioned this pull request Jul 1, 2024
Closed
@renan061 renan061 force-pushed the feature/tooling-snapshots branch from a97dec4 to 812ad4c Compare July 1, 2024 21:36
@renan061 renan061 marked this pull request as ready for review July 2, 2024 15:59
@marcelstanley marcelstanley requested a review from a team July 12, 2024 18:55
@renan061 renan061 force-pushed the feature/emulator-bindings branch from 46438d4 to 96f8253 Compare July 16, 2024 16:43
@renan061 renan061 force-pushed the feature/tooling-snapshots branch from 812ad4c to df3d6c6 Compare July 16, 2024 16:46
@renan061 renan061 force-pushed the feature/emulator-bindings branch from 96f8253 to 7cc7f11 Compare July 19, 2024 16:31
@renan061 renan061 force-pushed the feature/tooling-snapshots branch from df3d6c6 to 370cb46 Compare July 19, 2024 16:33
GMKrieger
GMKrieger previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@GMKrieger GMKrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmoura
Copy link
Contributor

fmoura commented Jul 24, 2024

Maybe current /internal/machine/snapshot.go that takes a snapshot from a previous existing machine docker image should be moved to this new tooling package. It has the same functionality, and still can be useful when testing against actual applications

fmoura
fmoura previously approved these changes Jul 24, 2024
View reviewed changes
marcelstanley
marcelstanley reviewed Jul 25, 2024
View reviewed changes
test/snapshot/snapshot.go Show resolved Hide resolved
test/snapshot/snapshot.go Show resolved Hide resolved
test/snapshot/snapshot.go Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the feature/emulator-bindings branch 2 times, most recently from 0e3d66a to a747e20 Compare August 8, 2024 14:25
@renan061 renan061 force-pushed the feature/tooling-snapshots branch from 370cb46 to 61a4044 Compare August 8, 2024 14:28
@renan061
Copy link
Contributor Author

renan061 commented Aug 8, 2024 •
edited
Loading

After revisiting the code, I renamed the property Dir to path, making it private, and added the Path() method.

@renan061 renan061 force-pushed the feature/tooling-snapshots branch from 61a4044 to cbedaf4 Compare August 8, 2024 15:23
@renan061
Copy link
Contributor Author

renan061 commented Aug 8, 2024

Maybe current /internal/machine/snapshot.go that takes a snapshot from a previous existing machine docker image should be moved to this new tooling package. It has the same functionality, and still can be useful when testing against actual applications

Yeah, we should do this. I'm adding it to the technical debt list.

marcelstanley
marcelstanley previously approved these changes Aug 15, 2024
View reviewed changes
@renan061 renan061 force-pushed the feature/emulator-bindings branch from a747e20 to 8870048 Compare August 15, 2024 16:47
Base automatically changed from feature/emulator-bindings to next/2.0 August 15, 2024 16:57
@renan061 renan061 dismissed stale reviews from marcelstanley and fmoura August 15, 2024 16:57

The base branch was changed.

@renan061 renan061 dismissed GMKrieger’s stale review August 15, 2024 16:57

The base branch was changed.

@renan061 renan061 force-pushed the feature/tooling-snapshots branch from cbedaf4 to 04ffa77 Compare August 15, 2024 17:06
@renan061 renan061 changed the title feat: add tooling for creating snapshots programmatically feat(advancer): add tooling for creating snapshots programmatically Aug 22, 2024
@renan061 renan061 force-pushed the feature/tooling-snapshots branch from 04ffa77 to 23cf3d6 Compare August 23, 2024 20:11
@renan061 renan061 merged commit 23cf3d6 into next/2.0 Aug 23, 2024
6 checks passed
@renan061 renan061 deleted the feature/tooling-snapshots branch August 23, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMKrieger GMKrieger GMKrieger approved these changes

@vfusco vfusco vfusco approved these changes

@fmoura fmoura fmoura approved these changes

@marcelstanley marcelstanley Awaiting requested review from marcelstanley

Assignees

@renan061 renan061

Labels
#feat:ci Feature: continuous integration #feat:machine-advancer Feature: machine advancer #feat:tests Feature: tests
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@renan061 @fmoura @vfusco @marcelstanley @GMKrieger