-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update the Dockerfile with emulator dependencies #435
Conversation
e2a335e
to
7ec5c8d
Compare
45adcb7
to
fb685af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming it would be preferrable to have a single commit for most of the changes related to the emulator and the CI. In that case, it would be helpful it the commit contained a more thorough explanation about their purpose as the commit message does not convey much about it.
Also, in order to make the changes clearer in the diff, I'd suggest either creating a separate commit for the formatting changes or reverting them altogether. This would help a lot with reviewing Dockerfile
and build/docker-bake.hcl
(it's a bit hard to identify the upgrades being made to the versions)
229a17c
to
78a2acb
Compare
I've update the commit message with more information. Separating the refactor in another commit would further delay this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just reinstate the linux/arm64 platform now that we know that xgenext2fs has a build for it. Other than that, it looks good to me 👌🏽
78a2acb
to
12f069d
Compare
Fixed Regarding the documentation for targets, I edited each stage to make sure the same text is still there. Because |
12f069d
to
5b38dac
Compare
- Adds linux.bin and rootfs.ext2 download to the emulator stage. - Adds a emulator-devel stage that install libcmt and xgenext2fs. - Configures the CI image to use CGO. - Refactors the Dockerfile to improve readability.
5b38dac
to
e1b1e24
Compare
No description provided.