Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add bindings to emulator C API #335

Closed
wants to merge 2 commits into from
Closed

feat: Add bindings to emulator C API #335

wants to merge 2 commits into from

Conversation

mpernambuco
Copy link

Initial draft of the go bindings to the machine emulator C API

@gligneul gligneul requested a review from renan061 March 4, 2024 17:32
renan061
renan061 reviewed Mar 7, 2024
View reviewed changes
pkg/emulator/go.mod Outdated Show resolved Hide resolved
renan061
renan061 reviewed Mar 7, 2024
View reviewed changes
pkg/emulator/main.go Outdated Show resolved Hide resolved
renan061
renan061 reviewed Mar 7, 2024
View reviewed changes
pkg/emulator/main.go Outdated Show resolved Hide resolved
renan061
renan061 reviewed Mar 7, 2024
View reviewed changes
pkg/emulator/main.go Outdated Show resolved Hide resolved
renan061
renan061 previously requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@renan061 renan061 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the binding, Perna! :-)

I left a lot of comments, but they are mostly style changes so the code conforms to Go conventions.

Also, we should write this binding using the output unification branch from the start

@mpernambuco mpernambuco force-pushed the machine-emulator-bindings branch 9 times, most recently from 7f7ba3d to ba40481 Compare March 15, 2024 15:02
@mpernambuco mpernambuco requested a review from renan061 March 16, 2024 00:15
@renan061 renan061 self-assigned this Mar 21, 2024
@renan061 renan061 removed their request for review March 21, 2024 16:04
@renan061 renan061 linked an issue Mar 21, 2024 that may be closed by this pull request
Add rollupsmachine module #346
Open
4 tasks
@renan061 renan061 added the #feat:machine-advancer Feature: machine advancer label Mar 21, 2024
@renan061 renan061 added this to the 2.0.0 milestone Mar 21, 2024
@renan061 renan061 force-pushed the machine-emulator-bindings branch 3 times, most recently from 4c07a73 to ba87c29 Compare March 22, 2024 17:27
@renan061 renan061 marked this pull request as ready for review March 22, 2024 17:30
@renan061 renan061 force-pushed the machine-emulator-bindings branch from ba87c29 to 1f32f20 Compare March 22, 2024 17:30
@renan061 renan061 dismissed their stale review March 22, 2024 17:31

Stale.

@renan061 renan061 requested a review from gligneul March 22, 2024 17:31
gligneul
gligneul approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it, but first, we should fix the CI by installing the machine emulator.

@renan061 renan061 force-pushed the machine-emulator-bindings branch from 1f32f20 to 8b78778 Compare March 24, 2024 01:12
@renan061 renan061 mentioned this pull request Apr 16, 2024
Open
49 tasks
@marcelstanley marcelstanley added the on hold Blocked by external reasons label May 21, 2024
@renan061 renan061 mentioned this pull request May 22, 2024
Merged
@renan061
Copy link
Contributor

Moved to #424.

@renan061 renan061 closed this May 22, 2024
@renan061 renan061 removed a link to an issue Jun 24, 2024
Add rollupsmachine module #346
Open
4 tasks
@renan061 renan061 deleted the machine-emulator-bindings branch July 8, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

@renan061 renan061 renan061 left review comments

Assignees

@mpernambuco mpernambuco

@renan061 renan061

Labels
#feat:machine-advancer Feature: machine advancer on hold Blocked by external reasons
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mpernambuco @renan061 @gligneul @marcelstanley