feat: add getNumberOfInputsBeforeCurrentBlock #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzzzHui
reviewed
Jan 13, 2025
| return snapshot.numberOfInputsBeforeBlock; | ||
| } else { | ||
| // snapshot.blockNumber < block.number | ||
| return getNumberOfInputs(appContract); |
There was a problem hiding this comment.
what's the reason for using getNumberOfInputs rather than snapshots here :)
There was a problem hiding this comment.
Because _snapshots only holds the index of the first input of the block.
If we are not in the same block in which the last snapshot was taken, then we have to return the total number of inputs up until now.
Let me illustrate:
at first, snapshot = (block=0, #inputs=0)
then an input is added on block 7, snapshot = (block=7, #inputs=1)
another input is added on block 7, snapshot = (block=7, #inputs=1) [the same]
then an input is added on block 8, snapshot = (block=8, #inputs=3)
another input is added on block 8, snapshot = (block=8, #inputs=3) [the same]
now, we're on block 42
if we used the snapshot, it would return 3,
but before the current block (42), there are 4 inputs already
so we need to use the current number of inputs
There was a problem hiding this comment.
I see. Yeah it's clear. Thanks for the illustration!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.