Split iflags into 4 registers #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpernambuco This may impact solidity step, because we don't have to read iflags anymore when we want to write part of it. I think this may be automatic in the uarch, but may not be automatic in send_cmio_response. Can you check? |
This simplifies the implementation and paves the way for a lot of further simplifications.
diegonehab
force-pushed
the
refactor/split-iflags
branch
from
1f7c63c to
0b141d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the iflags register in to 4 64-bit registers: iprv, iflags_X, iflags_Y, iflags_H.
This simplifies the implementation and paves the way for a lot of further simplifications because we do not have to implement read/modify/write when accessing pieces of a single 64-bit register anymore.
This even reduces the number of accesses in the access-log for send_cmio_response.
The PR goes further and removes the special register access functions from the C and Lua API.
Now every access must go through cm_read_reg/cm_write_reg.