Feature/output unification v2 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolitzer
requested review from
edubart,
diegonehab and
a team
and removed request for
edubart
mpolitzer
force-pushed
the
feature/output-unification-v2
branch
2 times, most recently
from
e3a2d96 to
c210fd8
Compare
vfusco
requested changes
Jul 28, 2024
mpolitzer
force-pushed
the
feature/output-unification-v2
branch
from
c210fd8 to
6835971
Compare
vfusco
approved these changes
Jul 28, 2024
Outputs root hash merkle tree is the same for all inputs, we stop resetting it for each input (v1). With that the tree will grow indefinetely and thus we also increased its depth to 2^63 leafs.
The machine itself does not take any steps to restore its state, the the emulator driver / controller does. As such we cannot expect the machine to reset its own state and thus this test case makes no sense.
mpolitzer
force-pushed
the
feature/output-unification-v2
branch
from
6835971 to
c64854f
Compare
edubart
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
commits
feat: update test data due to prev_randao field
feat: output unification v2
Outputs root hash merkle tree is the same for all inputs, we stop
resetting it for each input (v1). With that the tree will grow
indefinetely and thus we also increased its height to support 2^63 leafs.
fix: remove invalid test case
The machine itself does not take any steps to restore its state, the
the emulator driver / controller does. As such we cannot expect the
machine to reset its own state and thus this test case makes no sense.