Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce the --user command line option #201

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

edubart
Copy link
Contributor

@edubart edubart commented Mar 19, 2024

This makes easier to test the cartesi machine as root, useful you are prototyping with virtio network and want to install packages. Also refactors how the default user is chosen, this is now set by tools init script (this is more appropriate since the user existence depends on it).

$ cartesi-machine --user=root id 

         .
        / \
      /    \
\---/---\  /----\
 \       X       \
  \----/  \---/---\
       \    / CARTESI
        \ /   MACHINE
         '

uid=0(root) gid=0(root) groups=0(root)

Halted
$ cartesi-machine id 

         .
        / \
      /    \
\---/---\  /----\
 \       X       \
  \----/  \---/---\
       \    / CARTESI
        \ /   MACHINE
         '

uid=1000(dapp) gid=1000(dapp) groups=1000(dapp)

Depends on

@edubart edubart added enhancement New feature or request refactor Restructuring code, while not changing its original functionality labels Mar 19, 2024
@edubart edubart requested a review from vfusco March 19, 2024 16:07
@edubart edubart self-assigned this Mar 19, 2024
@edubart edubart added this to the v0.17.0 milestone Mar 19, 2024
vfusco
vfusco previously approved these changes Mar 19, 2024
@edubart edubart requested review from vfusco and a team March 20, 2024 12:11
@diegonehab diegonehab self-requested a review March 20, 2024 14:18
@vfusco vfusco merged commit 77fb173 into main Mar 20, 2024
8 checks passed
@vfusco vfusco deleted the feature/user-option branch March 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Restructuring code, while not changing its original functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants