Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation when using a new xxd (tested with 2024-01-17) #176

Closed
wants to merge 4 commits into from
Closed

Fix compilation when using a new xxd (tested with 2024-01-17) #176

wants to merge 4 commits into from

Conversation

mpolitzer
Copy link
Contributor

close #175

@mpolitzer mpolitzer requested review from mpernambuco and a team January 25, 2024 17:31
@mpolitzer mpolitzer self-assigned this Jan 25, 2024
@mpolitzer mpolitzer changed the base branch from main to feature/move-tests January 25, 2024 17:31
@mpernambuco
Copy link
Collaborator

Looks good to me.
It built fine on the Mac.
CI is broken, though.

@vfusco vfusco force-pushed the feature/move-tests branch 8 times, most recently from 4a53408 to 7932e52 Compare January 30, 2024 11:59
@mpolitzer
Copy link
Contributor Author

Implemented in: #180

@mpolitzer mpolitzer closed this Feb 1, 2024
@mpolitzer mpolitzer deleted the fix/new-xxd branch February 1, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpernambuco mpernambuco Awaiting requested review from mpernambuco

Assignees

@mpolitzer mpolitzer

Labels
None yet
Projects
Machine Emulator SDK
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newer versions of xxd use size_t instead of unsigned int causing a compilation error on uarch-pristine-ram.c
3 participants
@mpolitzer @mpernambuco @vfusco