refactor: replace libb64 with custom base64 implementation #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edubart
added
the
refactor
diegonehab
reviewed
Oct 30, 2023
diegonehab
reviewed
Oct 30, 2023
edubart
force-pushed
the
feature/replace-b64
branch
2 times, most recently
from
c954ce8 to
14850b3
Compare
edubart
force-pushed
the
feature/replace-b64
branch
from
14850b3 to
08331eb
Compare
edubart
force-pushed
the
feature/replace-b64
branch
from
08331eb to
fddca22
Compare
diegonehab
approved these changes
Oct 31, 2023
vfusco
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to simplify our dependencies, so the cartesi machine is easier to build on more platforms.
The base64 implementation was copied from LuaSocket code which @diegonehab himself wrote.