-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rollup rework #136
feat: rollup rework #136
Conversation
7512b6c
to
24f202e
Compare
beaa590
to
1f0390b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we are removing exceptions and reports yet. So let's keep the names. Also, see comments in code. There was a recent merge in main, so please rebase.
1f0390b
to
c5068bc
Compare
0373768
to
ee1e8b9
Compare
5b4e63f
to
fff6511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
fff6511
to
b5ff909
Compare
b5ff909
to
9f3c65d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and only found minor issues while testing locally.
cb2b954
to
62abd09
Compare
add option to print hashes on inspects perform snapshot/rollback for inspects
Added create-machines.lua from the cartesi/server-manager
also align name "output-hashes-root-hash" with solidity
62abd09
to
ad09b84
Compare
This PR simplifies the cartesi machine rollup by removing
input-metadata
,voucher_hashes
andnotice_hashes
.input-metadata
contents will be integrated into the rollupinput
, details are yet to be determined.vouchers
,notices
and other types of messages will now be encoded in userspace. The cartesi-machine and the linux driver will treat them as binary blobs.yield
will now pass the blob size in its data field. This way we won't need to inspect the encoded data.test