refactor: discard unused variables using std::ignore

src/clint-factory.cpp

@@ -25,9 +25,8 @@
 namespace cartesi {
 
 /// \brief CLINT device peek callback. See ::pma_peek.
-static bool clint_peek(const pma_entry &pma, const machine &m, uint64_t page_offset, const unsigned char **page_data,
-    unsigned char * /*scratch*/) {
-    (void) m;
+static bool clint_peek(const pma_entry &pma, const machine & /*m*/, uint64_t page_offset,
+    const unsigned char **page_data, unsigned char * /*scratch*/) {
     *page_data = nullptr;
     return (page_offset % PMA_PAGE_SIZE) == 0 && page_offset < pma.get_length();
 }

src/clint.cpp

@@ -61,9 +61,7 @@ static bool clint_read_mtimecmp(i_device_state_access *a, uint64_t *val, int log
 }
 
 /// \brief CLINT device read callback. See ::pma_read.
-static bool clint_read(void *context, i_device_state_access *a, uint64_t offset, uint64_t *val, int log2_size) {
-    (void) context;
-
+static bool clint_read(void * /*context*/, i_device_state_access *a, uint64_t offset, uint64_t *val, int log2_size) {
     switch (offset) {
         case clint_msip0_rel_addr:
             return clint_read_msip(a, val, log2_size);
@@ -78,10 +76,8 @@ static bool clint_read(void *context, i_device_state_access *a, uint64_t offset,
 }
 
 /// \brief CLINT device read callback. See ::pma_write.
-static execute_status clint_write(void *context, i_device_state_access *a, uint64_t offset, uint64_t val,
+static execute_status clint_write(void * /*context*/, i_device_state_access *a, uint64_t offset, uint64_t val,
     int log2_size) {
-    (void) context;
-
     switch (offset) {
         case clint_msip0_rel_addr:
             if (log2_size == 2) {

src/clua.cpp

@@ -60,15 +60,15 @@ static void fprint_str(FILE *out, const char *str, int max) {
     int m = max;
     for (i = 0; m > 0 && str[i]; ++i) {
         if (isprint(str[i])) {
-            (void) fputc(str[i], out);
+            std::ignore = fputc(str[i], out);
             m -= 1;
         } else {
-            (void) fprintf(out, "\\0x%02x", static_cast<unsigned char>(str[i]));
+            std::ignore = fprintf(out, "\\0x%02x", static_cast<unsigned char>(str[i]));
             m -= 5;
         }
     }
     if (str[i]) {
-        (void) fprintf(out, "...");
+        std::ignore = fprintf(out, "...");
     }
 }
 
@@ -77,9 +77,9 @@ void clua_print(lua_State *L, int idx) {
     lua_getglobal(L, "tostring");
     lua_pushvalue(L, idx);
     lua_call(L, 1, 1);
-    (void) fprintf(stderr, "%02d: ", idx);
+    std::ignore = fprintf(stderr, "%02d: ", idx);
     fprint_str(stderr, lua_tostring(L, -1), 68);
-    (void) fputc('\n', stderr);
+    std::ignore = fputc('\n', stderr);
     lua_pop(L, 1);
 }
 

src/htif-factory.cpp

@@ -26,9 +26,8 @@
 namespace cartesi {
 
 /// \brief HTIF device peek callback. See ::pma_peek.
-static bool htif_peek(const pma_entry &pma, const machine &m, uint64_t page_offset, const unsigned char **page_data,
-    unsigned char * /*scratch*/) {
-    (void) m;
+static bool htif_peek(const pma_entry &pma, const machine & /*m*/, uint64_t page_offset,
+    const unsigned char **page_data, unsigned char * /*scratch*/) {
     *page_data = nullptr;
     return (page_offset % PMA_PAGE_SIZE) == 0 && page_offset < pma.get_length();
 }

src/htif.cpp

@@ -32,9 +32,7 @@ static constexpr auto htif_iconsole_rel_addr = static_cast<uint64_t>(htif_csr::i
 static constexpr auto htif_iyield_rel_addr = static_cast<uint64_t>(htif_csr::iyield);
 
 /// \brief HTIF device read callback. See ::pma_read.
-static bool htif_read(void *context, i_device_state_access *a, uint64_t offset, uint64_t *pval, int log2_size) {
-    (void) context;
-
+static bool htif_read(void * /*context*/, i_device_state_access *a, uint64_t offset, uint64_t *pval, int log2_size) {
     // Our HTIF only supports 64-bit reads
     if (log2_size != 3) {
         return false;
@@ -64,7 +62,6 @@ static bool htif_read(void *context, i_device_state_access *a, uint64_t offset,
 }
 
 static execute_status htif_halt(i_device_state_access *a, uint64_t cmd, uint64_t data) {
-    (void) a;
     if (cmd == HTIF_HALT_CMD_HALT && ((data & 1) != 0)) {
         a->set_iflags_H();
         return execute_status::success_and_halt;
@@ -74,8 +71,7 @@ static execute_status htif_halt(i_device_state_access *a, uint64_t cmd, uint64_t
     return execute_status::success;
 }
 
-static execute_status htif_yield(i_device_state_access *a, uint64_t cmd, uint64_t data) {
-    (void) data;
+static execute_status htif_yield(i_device_state_access *a, uint64_t cmd, uint64_t /*data*/) {
     execute_status status = execute_status::success;
     // If yield command is enabled, yield and acknowledge
     if (cmd < 64 && (((a->read_htif_iyield() >> cmd) & 1) != 0)) {