-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autogenerated license information for rootfs.ext2 #80
Conversation
7b559e2
to
8fdff99
Compare
36907f5
to
5da5e28
Compare
@@ -5,3 +5,4 @@ libcmt* | |||
.github | |||
.git | |||
*.md | |||
fs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we track files in this directory?
Can you confirm you intention by doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are making a bit of a mess here. We have a Dockerfile
outside the fs/
directory and others inside it. The external Dockerfile
does not depend on anything that exists inside the fs/
directory. So as far as it's concerned, it's fine to have fs
in .dockerignore
. The fs/Dockerfile
depends only on fs/Dockerfile
itself. So it doesn't really care. If there was some file, say fs/foo.txt
on which fs/Dockerfile
depended, and if fs/Dockerfile
was built from the outside using the outside as the build context, then this .dockerignore
would be a problem. We do build from outside using the outside as build context to pick the TOOLS_DEB, but there is nothing inside fs/
that we care about when building rootfs.ext2
. Did I miss something?
.github/workflows/main.yml
Outdated
@@ -2,14 +2,14 @@ name: Build | |||
on: [push] | |||
jobs: | |||
build: | |||
needs: [test] | |||
# needs: [test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"It's just not a requirement of the build."
Guess not
@@ -0,0 +1,31 @@ | |||
# Modified from the original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is to do this in two commits instead:
Commit 1) add the original file only
Commit 2) apply the modifications
This way we can find if and where the original authors copyrighted code is by doing a git blame on this file. And additionally remove this comment.
@@ -0,0 +1,97 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion applies to this file.
5da5e28
to
20e8ae2
Compare
20e8ae2
to
1ae7f44
Compare
As we prepare to offer rootfs.ext2 as packages, we will have to refer to some place where users can check the licenses of all packages installed inside it. This PR creates and exports a new artifact that allows for the following release notes to be added to packages: