Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autogenerated license information for rootfs.ext2 #80

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

diegonehab
Copy link
Contributor

@diegonehab diegonehab commented Sep 13, 2024

As we prepare to offer rootfs.ext2 as packages, we will have to refer to some place where users can check the licenses of all packages installed inside it. This PR creates and exports a new artifact that allows for the following release notes to be added to packages:

The root filesystem for the Cartesi Machine Emulator provides a default filesystem that can be
used to boot Linux in the emulator. This package installs what is, essentially, a Docker image
converted to an ext2 filesystem image. The license shown for the package is what amounts to the
license of the associated Dockerfile. The image, in contrast, includes a variety of packages, each
with its own license. To see a list of packages in the ext2 filesystem image and their
corresponding licenses, please see
https://github.com/cartesi/machine-emulator-tools/releases/download/v0.16.2-test2/rootfs-tools-v0.16.2-test2.ext2.html

@diegonehab diegonehab force-pushed the feature/add-etc-licenses-to-rootfs branch 14 times, most recently from 7b559e2 to 8fdff99 Compare September 20, 2024 15:17
@diegonehab diegonehab force-pushed the feature/add-etc-licenses-to-rootfs branch 5 times, most recently from 36907f5 to 5da5e28 Compare October 2, 2024 20:08
@diegonehab diegonehab changed the title Add autogenerated etc/LICENSES to rootfs Add autogenerated license information for rootfs.ext2 Oct 2, 2024
edubart
edubart previously approved these changes Oct 2, 2024
@@ -5,3 +5,4 @@ libcmt*
.github
.git
*.md
fs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we track files in this directory?
Can you confirm you intention by doing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are making a bit of a mess here. We have a Dockerfile outside the fs/ directory and others inside it. The external Dockerfile does not depend on anything that exists inside the fs/ directory. So as far as it's concerned, it's fine to have fs in .dockerignore. The fs/Dockerfile depends only on fs/Dockerfile itself. So it doesn't really care. If there was some file, say fs/foo.txt on which fs/Dockerfile depended, and if fs/Dockerfile was built from the outside using the outside as the build context, then this .dockerignore would be a problem. We do build from outside using the outside as build context to pick the TOOLS_DEB, but there is nothing inside fs/ that we care about when building rootfs.ext2. Did I miss something?

@@ -2,14 +2,14 @@ name: Build
on: [push]
jobs:
build:
needs: [test]
# needs: [test]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP?

Copy link
Collaborator

@mpolitzer mpolitzer Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It's just not a requirement of the build."

Guess not

@@ -0,0 +1,31 @@
# Modified from the original
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is to do this in two commits instead:
Commit 1) add the original file only
Commit 2) apply the modifications

This way we can find if and where the original authors copyrighted code is by doing a git blame on this file. And additionally remove this comment.

@@ -0,0 +1,97 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion applies to this file.

@diegonehab diegonehab force-pushed the feature/add-etc-licenses-to-rootfs branch from 5da5e28 to 20e8ae2 Compare October 3, 2024 13:28
@diegonehab diegonehab force-pushed the feature/add-etc-licenses-to-rootfs branch from 20e8ae2 to 1ae7f44 Compare October 3, 2024 13:37
@diegonehab diegonehab merged commit 1ae7f44 into main Oct 4, 2024
6 checks passed
@diegonehab diegonehab deleted the feature/add-etc-licenses-to-rootfs branch October 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants