stronger types for: address, u256 and bytes #63
Conversation
mpolitzer
force-pushed
the
feat/prevrandao-u256
branch
from
d471727 to
168c3f9
Compare
mpolitzer
force-pushed
the
feat/prevrandao-u256
branch
2 times, most recently
from
aced6d8 to
1b22cc9
Compare
| @@ -258,7 +258,9 @@ pub fn rollup_read_advance_state_request( | |||
| app_contract: Default::default(), | |||
| block_number: 0, | |||
| block_timestamp: 0, | |||
| prev_randao: Default::default(), | |||
| prev_randao: { cmt_u256_t { | |||
There was a problem hiding this comment.
| prev_randao: { cmt_u256_t { | |
| prev_randao: { cmt_abi_u256_t { |
There was a problem hiding this comment.
Should we use EVM instead of ABI? Or even EVMABI... I don't know how this will progress and if different ABIs will show up. Not a big deal. We can keep ABI and change it later when something else finally appears.
There was a problem hiding this comment.
This library was going to be called evm_... originally, so evm_abi_... in this case. But you know how naming things go...
We can keep ABI and change it later when something else finally appears.
ok
|
|
||
| /** EVM u256 in big endian format */ | ||
| typedef struct cmt_abi_u256 { | ||
| uint8_t data[CMT_WORD_LENGTH]; |
There was a problem hiding this comment.
Chan we change CMT_WORD_LENGTH to CMT_ABI_U256_LENGTH here? And elsewhere, can we change it to CMT_HASH_LENGTH or CMT_KECCAC_LENGTH wherever that is the thing with the size?
There was a problem hiding this comment.
Chan we change CMT_WORD_LENGTH to CMT_ABI_U256_LENGTH here?
sure
And elsewhere, can we change it to CMT_HASH_LENGTH or CMT_KECCAC_LENGTH wherever that is the thing with the size?
There is a CMT_KECCAK_LENGTH already in keccak.h
This allows users to build and link without a release installation by preserving the header files relative path and `-I<cmt-root-dir>/include` when building.
mpolitzer
force-pushed
the
feat/prevrandao-u256
branch
from
1b22cc9 to
ce96c95
Compare
mpolitzer
force-pushed
the
feat/prevrandao-u256
branch
from
a26da7d to
6a4629e
Compare
mpolitzer
force-pushed
the
feat/prevrandao
branch
from
96c4eed to
8188e84
Compare
No description provided.