Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use meson instead of Makefile #54

Closed
wants to merge 2 commits into from
Closed

Use meson instead of Makefile #54

wants to merge 2 commits into from

Conversation

mpolitzer
Copy link
Collaborator

  • generate coverage reports
  • generate static and dynamic libraries
  • generate pkgconfig file

refactor: move read/write file to util
- remove unreachable if block
@edubart
Copy link
Contributor

edubart commented May 2, 2024

I don't mind having this as long as this is non-mandatory, so there is still a way for me to compile libcmt from sources without meson (as an user). Just needing a C compiler and GNU make.

Maybe meson could be used for development, with mock implementation, debug options, tests, coverage, etc.
And a very simple makefile has just enough to compile and install in release mode, so libcmt is straightforward to build on systems without meson. But then we have to maintain two build systems, maybe it could be worth it if the sum of lines of having to maintain both build systems is less complex than having just a makefile with everything.

I think the same about the emulator, I am fine with using meson for development (as a developer), as long as I can use a simple makefile when packaging it in release mode (as an user compiling from sources or as a packager). With raw makefiles I can build the cartesi machine for example in very exotic systems like DOSBox, Haiku, FreeBSD, WASM, etc. Making meson mandatory would cut possible systems we could support, because meson brings a lot of dependencies (eg Python).

Base automatically changed from fix/cov to main May 6, 2024 12:47
@mpolitzer mpolitzer closed this May 10, 2024
@mpolitzer mpolitzer deleted the feat/meson branch May 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants