Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartesi-machine formula #4

Closed
wants to merge 1 commit into from
Closed

cartesi-machine formula #4

wants to merge 1 commit into from

Conversation

tuler
Copy link
Member

@tuler tuler commented Sep 6, 2024

/opt/homebrew/Cellar/cartesi-machine/0.18.1
├── AUTHORS
├── CHANGELOG.md
├── COPYING
├── INSTALL_RECEIPT.json
├── README.md
├── bin
│   ├── cartesi-machine
│   ├── cartesi-machine-stored-hash
│   ├── jsonrpc-remote-cartesi-machine
│   └── merkle-tree-hash
├── include
│   └── cartesi-machine
│       ├── htif-defines.h
│       ├── jsonrpc-machine-c-api.h
│       ├── machine-c-api.h
│       ├── machine-c-defines.h
│       ├── machine-c-version.h
│       ├── pma-defines.h
│       ├── rtc-defines.h
│       └── uarch-defines.h
├── lib
│   ├── libcartesi-0.18.dylib
│   ├── libcartesi.a
│   ├── libcartesi.dylib -> libcartesi-0.18.dylib
│   ├── libcartesi_jsonrpc-0.18.dylib
│   ├── libcartesi_jsonrpc.a
│   ├── libcartesi_jsonrpc.dylib -> libcartesi_jsonrpc-0.18.dylib
│   └── lua
│       └── 5.4
│           ├── cartesi
│           │   └── jsonrpc.so
│           └── cartesi.so
└── share
    ├── cartesi-machine
    │   ├── gdb
    │   │   ├── gdb.md
    │   │   └── gdbinit
    │   └── images
    │       ├── linux-6.5.13-ctsi-1-v0.20.0.bin
    │       ├── linux.bin -> linux-6.5.13-ctsi-1-v0.20.0.bin
    │       ├── rootfs-tools-v0.16.1.ext2
    │       └── rootfs.ext2 -> rootfs-tools-v0.16.1.ext2
    └── lua
        └── 5.4
            ├── cartesi
            │   ├── gdbstub.lua
            │   ├── proof.lua
            │   └── util.lua
            ├── cartesi-machine-stored-hash.lua
            └── cartesi-machine.lua

15 directories, 36 files

@tuler tuler force-pushed the feature/cartesi-machine branch from 0d9ff75 to c8a7db8 Compare September 6, 2024 05:42
@tuler tuler force-pushed the feature/cartesi-machine branch from c8a7db8 to d3ad72f Compare September 6, 2024 05:50
@tuler tuler mentioned this pull request Sep 6, 2024
1 task
@alexmikhalevich
Copy link

i see that you removed the bottle from the formula. what is the reason?

Copy link

@edubart edubart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve how the emulator is being built. But I can't test this, let some other MacOS user from the emulator team also review.

@edubart edubart linked an issue Sep 6, 2024 that may be closed by this pull request
1 task
@tuler
Copy link
Member Author

tuler commented Sep 6, 2024

i see that you removed the bottle from the formula. what is the reason?

Bottles will be built by the CI process, following https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/

Once you review the build process itself, and before merging, I'll label the PR and the build process should kick in.

See how the build worked at https://github.com/cartesi/homebrew-tap/actions/runs/10733173251 and the bottles are saved as artifacts.

When I label it it should save as release artifacts and I'll update the formula.

@alexmikhalevich
Copy link

i see that you removed the bottle from the formula. what is the reason?

Bottles will be built by the CI process, following https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/

Once you review the build process itself, and before merging, I'll label the PR and the build process should kick in.

See how the build worked at https://github.com/cartesi/homebrew-tap/actions/runs/10733173251 and the bottles are saved as artifacts.

When I label it it should save as release artifacts and I'll update the formula.

i think i am a bit confused. here are the docs i followed: https://docs.brew.sh/Bottles. they state that bottles should be declared in the formula as they are in the version from my repo.

what am i missing here?

@tuler
Copy link
Member Author

tuler commented Sep 6, 2024

Bottles will be built by the CI process, following https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/

what am i missing here?

As far as I’m understanding the formula will be updated automatically by the release process above.

I’ll test it now

@tuler tuler added the pr-pull Formula release label Sep 6, 2024
@github-actions github-actions bot closed this in 6dd70d8 Sep 6, 2024
@github-actions github-actions bot deleted the feature/cartesi-machine branch September 6, 2024 12:23
@tuler
Copy link
Member Author

tuler commented Sep 6, 2024

Looks like it worked beautifully
https://github.com/cartesi/homebrew-tap/actions/runs/10738266768/job/29781493204

@alexmikhalevich
Copy link

good to know! lets merge then

@tuler
Copy link
Member Author

tuler commented Sep 6, 2024

good to know! lets merge then

The CI closes and pushes the change.
It's all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-pull Formula release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brew formula
3 participants