-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cartesi-machine formula #4
Conversation
tuler
commented
Sep 6, 2024
0d9ff75
to
c8a7db8
Compare
c8a7db8
to
d3ad72f
Compare
i see that you removed the bottle from the formula. what is the reason? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve how the emulator is being built. But I can't test this, let some other MacOS user from the emulator team also review.
Bottles will be built by the CI process, following https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/ Once you review the build process itself, and before merging, I'll label the PR and the build process should kick in. See how the build worked at https://github.com/cartesi/homebrew-tap/actions/runs/10733173251 and the bottles are saved as artifacts. When I label it it should save as release artifacts and I'll update the formula. |
i think i am a bit confused. here are the docs i followed: https://docs.brew.sh/Bottles. they state that bottles should be declared in the formula as they are in the version from my repo. what am i missing here? |
As far as I’m understanding the formula will be updated automatically by the release process above. I’ll test it now |
Looks like it worked beautifully |
good to know! lets merge then |
The CI closes and pushes the change. |