Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed errors do config module #85

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

endersonmaia
Copy link
Contributor

This shall make it easier to implement new tests to the config module.

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: cf7a6dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@endersonmaia endersonmaia requested a review from tuler October 14, 2024 20:13
Copy link
Member

@tuler tuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review the usage of any in general

apps/cli/src/config.ts Outdated Show resolved Hide resolved
apps/cli/src/config.ts Outdated Show resolved Hide resolved
apps/cli/src/config.ts Outdated Show resolved Hide resolved
@endersonmaia endersonmaia self-assigned this Oct 15, 2024
@endersonmaia endersonmaia requested a review from tuler October 15, 2024 11:44
@endersonmaia endersonmaia merged commit 7204625 into feature/config-file Oct 15, 2024
2 checks passed
@endersonmaia endersonmaia deleted the feature/config-file-typed-error branch October 15, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants