Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from configuration #77

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Build from configuration #77

merged 4 commits into from
Oct 22, 2024

Conversation

tuler
Copy link
Member

@tuler tuler commented Sep 18, 2024

Implementation of configuration driven build and run
closes #31

There are a few functional and non-functional goals:

  • - remove avoid docker volume mapping and use stdin and stdout instead. This will avoid permissions problems on different Docker setups
  • - support execution of host binaries when they exist and fallback to docker execution if they don't. This can improve performance and reduce dependency on Docker.
  • - support multiple drives
  • - add support for squashfs drives
  • - add support for ext4 drives
  • - support empty drives
  • - support drives from TAR
  • - support drives from directory
  • - support pre-built drives
  • - add customization of cartesi machine boot

@tuler tuler requested a review from endersonmaia September 18, 2024 13:24
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 5391a5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tuler tuler force-pushed the feature/config-file branch 2 times, most recently from 0124885 to 86aa0d3 Compare October 11, 2024 16:51
@tuler tuler force-pushed the feature/config-file branch from f04af20 to 342d0b5 Compare October 14, 2024 15:37
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 30.54% 289 / 946
🔵 Statements 30.68% 294 / 958
🔵 Functions 37.41% 52 / 139
🔵 Branches 26.95% 117 / 434
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/cli/src/baseCommand.ts 0% 0% 0% 0% 40-50, 54, 58-60, 65-71, 67-70, 69, 72, 76, 81, 85, 88-112, 114, 118-127
apps/cli/src/config.ts 85.71% 75.82% 96.87% 85.45% 67-68, 178, 228, 235, 244, 259-261, 260, 262, 271, 273, 282, 284, 293, 297, 329, 331, 339, 341-346, 343, 345, 357, 383, 463-470
apps/cli/src/machine.ts 0% 0% 0% 0% 4-19, 5-10, 9, 11-13, 12, 14-16, 15, 18, 21-112, 26, 37, 40-41, 41, 44-53, 46-48, 47, 50-52, 51, 56-58, 57, 62-63, 65-67, 66, 69-71, 70, 74-84, 83, 85-87, 86, 88-90, 89, 91-93, 92, 94-96, 95, 97-99, 98, 100-102, 101, 103-105, 104, 107-111
apps/cli/src/builder/directory.ts 100% 100% 100% 100%
apps/cli/src/builder/docker.ts 91.42% 78.57% 75% 94.11% 38, 122-128
apps/cli/src/builder/empty.ts 100% 100% 100% 100%
apps/cli/src/builder/none.ts 100% 100% 100% 100%
apps/cli/src/builder/tar.ts 100% 100% 100% 100%
apps/cli/src/commands/build.ts 0% 0% 0% 0% 16-39, 22-38, 24, 27, 30, 33, 36, 42, 44-45, 47, 49-59, 62, 65, 68, 71, 74, 77-82, 80-81, 85, 87-90, 89, 93-94, 97, 100, 102
apps/cli/src/commands/shell.ts 0% 0% 0% 0% 9, 11, 13-18, 20-36, 39, 42, 45, 48-56, 49-55, 52-54, 59-64, 67, 70, 73, 76, 79
apps/cli/src/exec/crane.ts 88.88% 50% 100% 88.88% 25
apps/cli/src/exec/genext2fs.ts 95.83% 62.5% 100% 95.65% 89
apps/cli/src/exec/mksquashfs.ts 85.71% 62.5% 100% 85% 69-70, 72
Generated in workflow #197 for commit 5391a5f by the Vitest Coverage Report Action

@tuler tuler force-pushed the feature/config-file branch 5 times, most recently from d9126ea to 7e0dc7f Compare October 17, 2024 18:04
@tuler tuler added the v2 label Oct 17, 2024
@tuler tuler changed the base branch from main to prerelease/v2-alpha October 17, 2024 23:07
@tuler tuler force-pushed the feature/config-file branch from 7e0dc7f to 6b91355 Compare October 18, 2024 15:20
@tuler tuler changed the base branch from prerelease/v2-alpha to feature/cli-v2 October 18, 2024 15:21
@tuler tuler force-pushed the feature/config-file branch 2 times, most recently from 0b4cbf6 to f2cfc29 Compare October 22, 2024 15:44
@tuler tuler force-pushed the feature/config-file branch from ca2fcba to 965cb96 Compare October 22, 2024 16:33
@tuler tuler force-pushed the feature/config-file branch from 965cb96 to 5391a5f Compare October 22, 2024 16:36
@tuler tuler marked this pull request as ready for review October 22, 2024 16:36
@tuler tuler requested a review from endersonmaia October 22, 2024 16:38
@tuler tuler merged commit 842170f into feature/cli-v2 Oct 22, 2024
2 checks passed
@tuler tuler deleted the feature/config-file branch October 22, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration driven commands
2 participants