feat: support for multiple sdks and abstract machine making into create_image script in sdk #24
Conversation
|
There was a problem hiding this comment.
Install changesets and add a changset file where you propose the minor version bump for the cartesi/sdk package.
apps/cli/src/commands/build.ts
Outdated
| @@ -19,6 +19,7 @@ type ImageInfo = { | |||
| env: string[]; | |||
| ramSize: string; | |||
| sdkVersion: string; | |||
| sdkType: string; | |||
There was a problem hiding this comment.
I suggest making this variable consistent with the label.
sdkNameCARTESI_LABEL_SDK_NAMEio.cartesi.rollups.sdk_name
stskeeps
force-pushed
the
feat/multiple-sdk
branch
from
ee546bd to
bb054ff
Compare
…te_image script in sdk Signed-off-by: Carsten Munk <[email protected]>
stskeeps
force-pushed
the
feat/multiple-sdk
branch
from
bb054ff to
fa82ab2
Compare
There was a problem hiding this comment.
@stskeeps changeset will take care of updating the CHANGELOG and package.json files when changes hit the main branch, a GH Actions job will create/update the Release PR.
Since this PR has changes for two packages with a dependency between them, we'd need to have the changes in separate PRs.
The first one is with changes to the cartesi/sdk package, so we can release it first. Another PR with changes to the cartesi/cli making use of the new cartesi/sdk.
|
OK, so close this pull request and I've opened as a start #26 - this is the style desired right? |
This probably requires upping CARTESI_DEFAULT_SDK_VERSION as well.