Feat/add cruntime for machine sdk 17 use tar stream

[endersonmaia]

Attempt to use tar-stream instead of nanotar.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 7b68190

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[tuler]

how do I test this?
it complains about cartesi/cruntime:0.1.0. How do I build it?

[tuler]

this looks out of place. because you will add more entries (for each gnuTar entry)

[endersonmaia]

I did some changes in a fixup, but the .cartesi/app.ocibuindle.tar is still incomplete.

I don't fully understand how these streams are supposed to work, something is missing to close/finish the tar, since I never hit the console.log() at lines 388 and 392.

But .cartesi/app.ocibuindle.tar has config.json and rootfs/ prefix there.

[endersonmaia]

When you build the cruntime package , you,d need to relabel :devel as :0.1.0 docker image tag cartesi/cruntime:devel cartesi/cruntime:0.1.0 Em seg., 6 de mai. de 2024, 20:10, Danilo Tuler ***@***.***> escreveu:

…

***@***.**** commented on this pull request. how do I test this? it complains about cartesi/cruntime:0.1.0. How do I build it? ------------------------------ In apps/cli/src/commands/build.ts <#17 (comment)>: > @@ -419,29 +362,60 @@ Update your application Dockerfile using one of the templates at https://github. appGnutarPath, ); + // prepare OCI Bundle + const extract = tar.extract(); + const pack = tar.pack(); + const appGnuTarStream = fs.createReadStream(appGnutarPath); + const appOCIBundleStream = fs.createWriteStream(appOCIBundlePath); + const ociConfigJSON = JSON.stringify(createConfig(imageInfo)); + + // add config.json + pack.entry({ name: "config.json" }, ociConfigJSON, function (err) { + if (err) throw err; + console.log("ERROR config.json"); + pack.finalize(); this looks out of place. because you will add more entries (for each gnuTar entry) — Reply to this email directly, view it on GitHub <#17 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAC4UGJHPY6WQPDTXDFDLZA7IRHAVCNFSM6AAAAABHJO4D3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBRGQ4DMOJXHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[endersonmaia]

how do I test this? it complains about cartesi/cruntime:0.1.0. How do I build it?

I recommend testing the draft branch PR #12 branch, to see the cruntime working, and this PR is an improvemente so we don't create a --flash-driver just for the config.json.