-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate infrastructure into pyproject.tml
#30
consolidate infrastructure into pyproject.tml
#30
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
========================================
Coverage 100.0% 100.0%
========================================
Files 3 2 -1
Lines 328 127 -201
========================================
- Hits 328 127 -201
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked a buncha this stuff locally. And looked up all the packages. It looks pretty straight-forward. Left a few questions of clarification for you.
Co-authored-by: Carson Farmer <[email protected]>
Sounds good. I've left some justifications and will wait for your re-review. |
This PR:
pyproject.tml
fastpair==0.1.0
causing on issue on install #29scipy>=1.10,<1.12
fastpairs
not compatible withscipy>=1.12
#22 is addressedsetup tools_scm
, which tracks tags to determine current release and guessed current development version. For example:v0.1.0
v0.1.1.dev3+g4ec960e.d20240529
v0.1.1
3
commits since thev0.1.0
tagg4ec960e.d20240529
@carsonfarmer I am not trying to pull a quick one on you or move faster than you are comfortable. Please do not hesitate to raise any questions/concerns if these changes are overwhelming (or you simply need clarification).