Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate infrastructure into pyproject.tml #30

Merged

Conversation

jGaboardi
Copy link
Collaborator

@jGaboardi jGaboardi commented May 29, 2024

This PR:

  • consolidate infrastructure into pyproject.tml
  • resolves [INFRA] tag fastpair==0.1.0 causing on issue on install #29
  • sets two pins to scipy: scipy>=1.10,<1.12
  • moves to dynamic versioning with setup tools_scm, which tracks tags to determine current release and guessed current development version. For example:
    • the current release is v0.1.0
    • (locally for me) the current guessed development state is v0.1.1.dev3+g4ec960e.d20240529
      • this means...
        • the next patch tag/release would be v0.1.1
        • there have been 3 commits since the v0.1.0 tag
        • the last commit hash ID is g4ec960e.d20240529
    • after each tag/release developers must reinstall for consistent versioning
  • xref interest in modernizing? #20

@carsonfarmer I am not trying to pull a quick one on you or move faster than you are comfortable. Please do not hesitate to raise any questions/concerns if these changes are overwhelming (or you simply need clarification).

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (4ec960e) to head (8a3840d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main      #30    +/-   ##
========================================
  Coverage   100.0%   100.0%            
========================================
  Files           3        2     -1     
  Lines         328      127   -201     
========================================
- Hits          328      127   -201     
Files Coverage Δ
fastpair/__init__.py 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@jGaboardi jGaboardi requested a review from carsonfarmer May 29, 2024 20:39
Copy link
Owner

@carsonfarmer carsonfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked a buncha this stuff locally. And looked up all the packages. It looks pretty straight-forward. Left a few questions of clarification for you.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
fastpair/__init__.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@jGaboardi
Copy link
Collaborator Author

I've checked a buncha this stuff locally. And looked up all the packages. It looks pretty straight-forward. Left a few questions of clarification for you.

Sounds good. I've left some justifications and will wait for your re-review.

@carsonfarmer carsonfarmer self-requested a review May 31, 2024 20:59
@jGaboardi jGaboardi merged commit 3d082b4 into carsonfarmer:main May 31, 2024
1 check passed
@jGaboardi jGaboardi deleted the GL20_consolidate_to_pyproject.toml branch May 31, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA] tag fastpair==0.1.0 causing on issue on install
3 participants