Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kicking off #20 - modernizing fastpairs #24

Merged

Conversation

jGaboardi
Copy link
Collaborator

@jGaboardi jGaboardi commented May 25, 2024

This PR kick of #20:

Important

@carsonfarmer Perhaps before merging this PR:

  • We should tag the current main with fastpair==0.1.0 to give a good point-in-time break
  • Then I can update this PR and add back in a simple version=0.1.0 into the setup.py
  • Once pyproejct.toml & setuptools-scm are adopted as described in interest in modernizing? #20, versioning will be automated by manual tagging.

@carsonfarmer
Copy link
Owner

Ok, I kicked off a tag (https://github.com/carsonfarmer/fastpair/tags) (and release) based on fastpair==0.1.0 (I'm not used to that x==y convention, so hopefully I did that right?).

branches:
- '*'
schedule:
- cron: '59 23 * * *'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the cron here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run nightly CI on main.

@jGaboardi
Copy link
Collaborator Author

fastpair==0.1.0 (I'm not used to that x==y convention

LOL whoops. That was simply my shorthand for meaning version 0.1.0; I should have been more clear.

I'll update the tag and release as v0.1.0. We'll start using the vX.Y.Z convention, as it is useful in pushing tags that kick off automated actions. See example here.

@jGaboardi jGaboardi self-assigned this May 27, 2024
@jGaboardi jGaboardi requested a review from carsonfarmer May 27, 2024 18:09
Copy link
Owner

@carsonfarmer carsonfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@carsonfarmer
Copy link
Owner

I generally follow the convention of, if you get a 👍 then you can merge your own PRs. Is this a good convention for you too?

@jGaboardi
Copy link
Collaborator Author

I generally follow the convention of, if you get a 👍 then you can merge your own PRs. Is this a good convention for you too?

I can get on board with that.

@jGaboardi jGaboardi merged commit 899f88c into carsonfarmer:main May 28, 2024
@jGaboardi jGaboardi deleted the GH20__modernize__pre__update_setup branch May 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants