-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kicking off #20 - modernizing fastpairs
#24
kicking off #20 - modernizing fastpairs
#24
Conversation
Ok, I kicked off a tag (https://github.com/carsonfarmer/fastpair/tags) (and release) based on |
branches: | ||
- '*' | ||
schedule: | ||
- cron: '59 23 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the cron here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run nightly CI on main
.
LOL whoops. That was simply my shorthand for meaning version I'll update the tag and release as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
I generally follow the convention of, if you get a 👍 then you can merge your own PRs. Is this a good convention for you too? |
I can get on board with that. |
This PR kick of #20:
setup.py
that was causing an error – remove portion ofsetup.py
to allow for install #23scipy=1.11
– [COMPAT]fastpairs
not compatible withscipy>=1.12
#22Important
@carsonfarmer Perhaps before merging this PR:
main
withfastpair==0.1.0
to give a good point-in-time breakversion=0.1.0
into thesetup.py
pyproejct.toml
&setuptools-scm
are adopted as described in interest in modernizing? #20, versioning will be automated by manual tagging.