Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Port to ES2016, Refactor & Enhancements #55

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Conversation

zspecza
Copy link
Contributor

@zspecza zspecza commented Dec 23, 2015

closes #31, #35, #39, #47, #49, #51, #53

  • add notes to docs regarding debugging requests
  • update code to ES2016
  • remove runtime dependency on lodash & when
  • swap out string.js for underscore.string
  • use Standard JS Style
  • add lint script
  • add pre-commit linting
  • remove risky unbuild step
  • upgrade tests
    • port current test suite to AVA
    • use nyc for coverage
    • improve test performance
      • run tests concurrently
      • add async: true option to roots-util test helpers (Test Helper Changes roots-util#7)
      • update roots-contentful tests to take advantage of the new async options in roots-util
    • improve test stability
    • reduce boilerplate
    • ensure separate test files don't modify the same fixture
    • assert error messages, not just the fact that errors are thrown
    • add missing test for asset_view_helper else path
    • add test case alongside roots-yaml and roots-records
      • roots-yaml
        • roots-contentful data in roots-yaml
        • roots-yaml data in roots-contentful
      • roots-records
        • roots-contentful data in roots-records
        • roots-records data in roots-contentful
  • new features
    • add locales support from add locale(s) support #39
    • add caching
      • internal logic
      • tests
    • add _path helper for single entry views
      • internal logic
      • tests
    • enable use of _url and _urls locals inside content types that reference each other
      • internal logic
      • tests
  • ensure documentation and contribution guidelines reflect the new changes

note to self: document that this is a breaking change which requires npm 3 and node 5

Update to bare minimal ES2016 syntax
update test to minimum required es6 syntax for easier lib refactoring
point to existing roots-contentful
@zspecza zspecza changed the title Port to ES-2016 [WIP] Port to ES2016 Jan 6, 2016
@hhsnopek
Copy link
Contributor

hhsnopek commented Jan 7, 2016

we should release this as v1.0.0 once stable :)

@zspecza zspecza changed the title [WIP] Port to ES2016 [WIP] Port to ES2016, Refactor & Enhancements Jan 11, 2016
@zspecza zspecza mentioned this pull request Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roots-contentful doesn't play well with roots-yaml
3 participants