-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for custom icons and colour schemes #241
Comments
N.B. This is very related to #66 |
Thanks for the lovely and useful package, @zkamvar, and thanks also for thinking about reuse of the template beyond The Carpentries! I was wondering if you could also add “favicon” to the list of customisation options, as a the moment it seems like that’s hard-coded as well. (EDIT: Oh, and the footer too! See https://learntodiscover.github.io/lesson2_sandpaper/ and https://contributor.r-project.org/r-bug-tracking-lesson/ for example.) Many thanks, once again! |
Of course! It's something that may take some time to get going since there are a few moving parts that dictate these (for example, see modifications in sandpaper and modifications in varnish needed to update the theme (note that Saba had to add a python and PDF engine to her version of sandpaper, so there's a lot more to her changes than styling)). Right now, I've painted myself into a corner by building the source into the minified version before the package is built. This means that the colours are hard-coded in the CSS. The icons are a bit more flexible since I have the In the meantime, one workaround that should work is:
The logo and colors are things I'm unlikely to change in varnish (until I work out the right path to allow for customisation), so you can keep up-to-date by merging and the github actions will regenerate the minified CSS once it gets to the main branch. |
Sounds ace! Thanks for documenting the alternative options. :) |
Right now we have a set of four colour schemes and logos based on our curricula. Of course, there are other organisations that use our infrastructure and would probably like to not have to create a new fork of varnish in order to use a different logo or colour scheme. Thus:
The text was updated successfully, but these errors were encountered: