Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on updating footer links missing #269

Open
RaoOfPhysics opened this issue Apr 7, 2022 · 5 comments
Open

Documentation on updating footer links missing #269

RaoOfPhysics opened this issue Apr 7, 2022 · 5 comments
Assignees

Comments

@RaoOfPhysics
Copy link

In addition to the request to customise the content of the footer (#241 (comment)), I also wanted to note that the links to Edit on Github, Contributing, Source and Cite are all linked to the template repo when a site is built using the template:

zkamvar added a commit to zkamvar/r-bug-tracking-lesson that referenced this issue Apr 7, 2022
This will address r-devel#2 and carpentries/sandpaper#269 by adding the URL and source metadata to ensure the footers link back to the source of the lesson.
@zkamvar
Copy link
Contributor

zkamvar commented Apr 7, 2022

Thank you for using the repo! This is one of the features that I need to document better. You can fix those footer links by modifying the source and url fields in config.yaml.

I've created r-devel/r-bug-tracking-lesson#13 to address this issue, but I will leave this issue open until I properly document this feature.

@RaoOfPhysics
Copy link
Author

Oh, many thanks for that! I should have looked more carefully at the config before filing the issue.

@zkamvar
Copy link
Contributor

zkamvar commented Apr 7, 2022

No worries at all! Thank you for the reporting!

@zkamvar zkamvar changed the title Footer links are hardcoded to the template repo Documentation on updating footer links missing Apr 7, 2022
@zkamvar zkamvar self-assigned this Apr 7, 2022
@RaoOfPhysics
Copy link
Author

Sorry if I missed it, @zkamvar, but can the Contact and About as well as the text saying All Carpentry lessons are subject to the [Code of Conduct](https://docs.carpentries.org/topic_folders/policies/code-of-conduct.html) be changed?

@zkamvar
Copy link
Contributor

zkamvar commented Apr 8, 2022

Sorry if I missed it, @zkamvar, but can the Contact and About as well as the text saying All Carpentry lessons are subject to the [Code of Conduct](https://docs.carpentries.org/topic_folders/policies/code-of-conduct.html) be changed?

The contact can be changed right now in https://github.com/r-devel/r-bug-tracking-lesson/blob/270fd0edbf759e1679eaa6f8fbdc454445e9b514/config.yaml#L37-L38

The CoC at the moment is hard-coded, but I can update that to either be another config item (e.g. coc: CODE_OF_CONDUCT.md or coc: https://www.contributor-covenant.org/version/1/2/0/code-of-conduct.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants