-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use format = "file" instead of tar_file #30
base: main
Are you sure you want to change the base?
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/targets-workshop/compare/md-outputs..md-outputs-PR-30 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-07-10 05:54:32 +0000 |
Thanks for the PR @multimeric ! I think this is related to a broader discussion of design philosophy of the lesson: should we use syntactic sugar to make the pipeline look nicer (and perhaps more like what a learner is likely to encounter in the wild), or stick to a limited number of more verbose functions to hopefully foster better learner comprehension? I think the best approach may be to use some of both. I freely admit my opinion on how much of each is biased by my personal preferences when writing {targets} pipelines. For example, I agree that However, I just taught the workshop myself again recently, and had no problem with
{tarchetypes} is also needed for |
Happy to discuss the merits of this. Basically I've found myself preferring to use
tar_target(format = "file")
instead oftar_file
. My motivations for this are:tarchetypes
dependency completely if we also stop usingtar_file_read
(see: Workshop feedback #22).