Minimize apt installed packages in Dockerfile #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `apt-get install` with `--no-install-recommends` to void unnecessary packages, and manually add `dbus` package to prevent build failure with command `pip install --no-cache-dir dbus-python PyGObject` like below: > #0 22.28 Program dbus-run-session found: NO > #0 22.28 > #0 22.28 ../test/meson.build:72:19: ERROR: Program 'dbus-run-session' not found or not executable
Codecov ReportPatch has no changes to coverable lines. ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. 📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
apt-get installwith--no-install-recommendsto void unnecessary packages, and manually adddbuspackage to prevent build failure with commandpip install --no-cache-dir dbus-python PyGObjectlike below:This is making the Docker image size smaller, also kind of a Dockerfile best practice:
Before:
After: