Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches required to build on koji server #936

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 27, 2023

Description:

Related issue (if applicable): #

Koji build for Fedora 39 consistently fails with the error:

=================================== FAILURES ===================================
____________________________ test_apprise_trans_add ____________________________
    @pytest.mark.skipif(
        'gettext' not in sys.modules, reason="Requires gettext")
    def test_apprise_trans_add():
        """
        API: Apprise() Gettext add
    
        """
    
        # This throws internally but we handle it gracefully
        al = AppriseLocale.AppriseLocale()
        with environ('LANGUAGE', 'LC_ALL', 'LC_CTYPE', 'LANG'):
            # English is the default/fallback type
>           assert al.add('en') is True
E           AssertionError: assert False is True
E            +  where False = <bound method AppriseLocale.add of <apprise.AppriseLocale.AppriseLocale object at 0x3ffb287f3e0>>('en')
E            +    where <bound method AppriseLocale.add of <apprise.AppriseLocale.AppriseLocale object at 0x3ffb287f3e0>> = <apprise.AppriseLocale.AppriseLocale object at 0x3ffb287f3e0>.add

Further investigation reveals that gettext isn't installed; when adding this the .mo (translation) files correctly get installed in subsequent Fedora packages on COPR builds, but still does not work on Koji.

This merge request at least offers a dirty band-aid for now so that Redhat/Oracle users can leverage the latest Apprise code until this is figured out.

image

For reference, here are the main files from the above build for reference:

This is the link to the build in question which reflect screenshot above for transparency: In about 1-3 months from now, the link will likely no longer be accessible since Fedora cleans up old builds - especially failing ones. But the logs and screenshot reflect what is important.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (be3baed) 99.52% compared to head (eb6e0e9) 99.52%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files         123      123           
  Lines       16360    16360           
  Branches     3329     3329           
=======================================
  Hits        16283    16283           
  Misses         68       68           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 524c1e9 into master Sep 9, 2023
12 checks passed
@caronc caronc deleted the fedora-gettext-fix branch October 8, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants