Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushMe Support Added #928

Merged
merged 2 commits into from
Aug 20, 2023
Merged

PushMe Support Added #928

merged 2 commits into from
Aug 20, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 19, 2023

Description:

Related issue (if applicable): #907

PushMe Support Added

  • Source: https://push.i-i.me/
  • Icon Support: No
  • Attachment Support: No
  • Message Format: Text
  • Message Limit: 32768 Characters per message

You need to have an account with PushMe and have downloaded the Phone App.

Note: The token is also referred to as the push_key

Parameter Breakdown

Variable Required Description
token Yes This is the push_key associated with your PushMe Account
status No Optionally include a small little ASCII string representing the notification status being sent (inline with it) by default this is set to yes.

Syntax

Valid syntax is as follows:

  • pushme://{token}/

New Service Completion Status

  • apprise/plugins/NotifyPushMe.py
  • KEYWORDS
    • add new service into this file (alphabetically).
  • README.md
    • add entry for new service to table (as a quick reference)
  • packaging/redhat/python-apprise.spec
    • add new service into the %global common_description

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@907-pushme-support

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "pushme://push_key"

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5fd568f) 99.51% compared to head (3601845) 99.51%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         123      123           
  Lines       16345    16349    +4     
  Branches     3329     3329           
=======================================
+ Hits        16266    16270    +4     
  Misses         70       70           
  Partials        9        9           
Files Changed Coverage Δ
apprise/plugins/NotifyPushMe.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc added blocked Blocked due to missing information and/or an issue outside of this project. awaiting public confirmation it works and removed blocked Blocked due to missing information and/or an issue outside of this project. labels Aug 19, 2023
@caronc caronc mentioned this pull request Aug 20, 2023
@caronc caronc merged commit 31caff1 into master Aug 20, 2023
12 checks passed
@caronc caronc deleted the 907-pushme-support branch October 8, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants