Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

details() consistency update for SNS and SES services #919

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 7, 2023

Description:

Related issue (if applicable): #918

Added more consistency to Apprise.details() output.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@918-consistent-details

# launch python instance
python

Now from inside of the python cli type:

from apprise import Apprise

apobj = Apprise()

# Test the details output:
apobj.details()

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (768b384) 99.98% compared to head (f686025) 99.98%.
Report is 1 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #919   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         122      122           
  Lines       16200    16200           
  Branches     3303     3303           
=======================================
  Hits        16198    16198           
  Misses          1        1           
  Partials        1        1           
Files Changed Coverage Δ
apprise/plugins/NotifySES.py 100.00% <ø> (ø)
apprise/plugins/NotifySNS.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit cd97084 into master Aug 7, 2023
14 checks passed
@caronc caronc deleted the 918-consistent-details branch August 14, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants