-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent gettext() from binding to _ namespace #821
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
==========================================
+ Coverage 99.51% 99.52% +0.01%
==========================================
Files 123 123
Lines 16345 16360 +15
Branches 3329 3329
==========================================
+ Hits 16266 16283 +17
+ Misses 70 68 -2
Partials 9 9
☔ View full report in Codecov by Sentry. |
0f18aad
to
8854635
Compare
8854635
to
b427987
Compare
dd5211f
to
d7ccec6
Compare
96b6a0b
to
91246bc
Compare
1c45bf1
to
0852b50
Compare
Description:
Related issue (if applicable): #807
Python states that while it provides the
gettext.install()
function (to install translations globally into the built-in (_
), it isn't ideal as the last person who calls this over-rides the global built-in. Basically system can do this, but plugins like Apprise should not.Python Official Reference
Key quote to take away from above link:
Checklist
flake8
)Testing
Anyone can help test this source code as follows: