-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WxPusher Support Added #1135
WxPusher Support Added #1135
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1135 +/- ##
========================================
Coverage 99.35% 99.35%
========================================
Files 146 147 +1
Lines 20186 20320 +134
Branches 3967 3979 +12
========================================
+ Hits 20055 20189 +134
Misses 121 121
Partials 10 10 ☔ View full report in Codecov by Sentry. |
10986b8
to
9221ffe
Compare
2e9065b
to
254bbc5
Compare
I made another change to completely drop This format now matches that of what is posted in their own plugin they have on github here edit: ping @codejiangqihan 🙂 |
@codejiangqihan, would love your feedback on this update (only because you've been so helpful in the past) |
After testing it, it seems that the return result is 200, but I still haven’t received the message on WeChat. I used the following two lines of commands to test. There was no error message, but I still did not receive any information on WeChat: apprise -t "Test Title" -b "Test Message" wxpusher://AT_11111/UID_11111 |
So wierd, I'm at a loss as to what to try next. I can't spot anything obvious. Hopefully someone else will see what's going on and resume or comment on this PR |
254bbc5
to
598c054
Compare
@codejiangqihan: I made some more changes after some further investigation. I think what is happening is i was looking at the wrong return code. so while Apprise was telling you the message was successfully sent, it really wasn't (this was misleading). This new change will likely have you get the same result (that the notification won't be sent), however now it should report the real reason why (wrong ID, wrong value, etc. But it will help us identify/pinpoint better. |
A small error caused the run to fail. # wxpusher.py
class WxPusherContentType:
"""
Defines the different supported content types
"""
TEXT = 0
HTML = 1
MARKDOWN = 2 The wxpusher documentation says this:
So I tried changing the code to the following: # wxpusher.py
class WxPusherContentType:
"""
Defines the different supported content types
"""
TEXT = 1
HTML = 2
MARKDOWN = 3 Test result:
It ran successfully and I got the message. |
This is amazing detective work on your part! ❤️🙏 Thank you so much! I'll update this and also add in the message lookups:
After that I'll merge the code! 🚀 |
Description:
Related issue (if applicable): #1133
Added WxPusher
Account Setup
Note: The above image was taken from WxPusher's Help Page
Targets can be either a User (
UID_DATA
) or a Topic (<integer>
). i.e:wxpusher://apptoken/123/343/UID_ABCD
would notify 2 topics (123
, and343
) plus one userUID_DATA
)Syntax
Valid syntax is as follows:
wxpusher://{app_token}@{userid}
wxpusher://{app_token}@{userid1}/{userid2}/{useridN}
wxpusher://{app_token}@{token}
wxpusher://{app_token}@{token1}/{token2}/{tokenN}
You can also mix/match topic's and user ids:
wxpusher://{app_token}@{token1}/{userid1}/...
Parameter Breakdown
AT_
New Service Completion Status
%global common_description
Checklist
flake8
)Testing
Anyone can help test this source code as follows:
Here is an example of notifying a topic:
Here is an example of notifying a user:
We can notify a variety of users/topics by just specifying htem on the path: