Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Storage #1131

Merged
merged 12 commits into from
Aug 23, 2024
Merged

Persistent Storage #1131

merged 12 commits into from
Aug 23, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented May 27, 2024

Description:

Related issue (if applicable): #749

Also fixes:

See: https://github.com/caronc/apprise/wiki/persistent_storage

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@749-persistent-storage

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  <apprise url related to ticket>

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.35%. Comparing base (4754052) to head (d958a84).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   99.26%   99.35%   +0.08%     
==========================================
  Files         144      146       +2     
  Lines       18795    20176    +1381     
  Branches     3611     3966     +355     
==========================================
+ Hits        18657    20045    +1388     
+ Misses        126      121       -5     
+ Partials       12       10       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apprise/url.py Dismissed Show resolved Hide resolved
@caronc caronc force-pushed the 749-persistent-storage branch 8 times, most recently from 776dad5 to a88ec90 Compare June 11, 2024 23:17
@caronc caronc force-pushed the 749-persistent-storage branch 4 times, most recently from 0186007 to ee2aea1 Compare July 2, 2024 18:08
apprise/url.py Fixed Show resolved Hide resolved
apprise/url.py Dismissed Show dismissed Hide dismissed
@caronc caronc force-pushed the 749-persistent-storage branch 3 times, most recently from 2a8d3a0 to a96e080 Compare August 23, 2024 00:11
@caronc caronc merged commit 827db52 into master Aug 23, 2024
14 checks passed
@caronc caronc deleted the 749-persistent-storage branch August 24, 2024 22:00
@caronc caronc mentioned this pull request Sep 2, 2024
4 tasks
@dgtlmoon
Copy link
Contributor

amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants