complete coverage of what is there

caronc · Oct 6, 2023 · 4c1b5ca · 4c1b5ca
1 parent f725b3a
commit 4c1b5ca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/apprise/conversion.py b/apprise/conversion.py
@@ -308,7 +308,7 @@ def handle_starttag(self, tag, attrs):
             self._preserver_cr = True
 
         elif tag == 'a':
-            for name, link in attrs:
+            for name, link in attrs:  # pragma: no branch
                 if name == 'href':
                     self._link = '(' + link + ')'
                     # Take an early exit for speed (in case there are more

diff --git a/test/test_conversion.py b/test/test_conversion.py
@@ -107,6 +107,11 @@ def to_html(body):
                    "<a href='#'>my link</a>") == \
         "test my link"
 
+    # a with missing href entry
+    assert to_html("<span></span<<span>test</span> "
+                   "<a>my link</a>") == \
+        "test my link"
+
     # </p> missing
     assert to_html("<body><div>line 1 <b>bold</b></div>  "
                    " <a href='#'>my link</a>"