Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize base template #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Customize base template #24

wants to merge 1 commit into from

Conversation

kasun
Copy link
Contributor

@kasun kasun commented Jun 20, 2023

As per discussion in #21 this PR adds support to customise base html template by declaring it as a class attribute in view classes.

  • Base template name defined as a class attribute.
  • Base template name is added to context data.
  • Change all template files to extend the base html template using variable passed to context data.
  • CRUDView documentation update.
  • Unit test to test base html override.

Addresse step 2 of #6

@kasun kasun mentioned this pull request Jun 20, 2023
Closed
@carltongibson carltongibson self-requested a review June 20, 2023 18:53
@carltongibson
Copy link
Owner

Thanks for this @kasun! 🎁

So you know, I just need a bit of time to sit down with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson Awaiting requested review from carltongibson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasun @carltongibson