Enhance unit tests for CodecService methods (elastic#111382)

carlosdelest · Jul 31, 2024 · 67e8b97 · 67e8b97
1 parent b3e8dae
commit 67e8b97
Showing 1 changed file with 25 additions and 0 deletions.
diff --git a/server/src/test/java/org/elasticsearch/index/codec/CodecTests.java b/server/src/test/java/org/elasticsearch/index/codec/CodecTests.java
@@ -38,7 +38,9 @@
 import org.hamcrest.Matchers;
 
 import java.io.IOException;
+import java.util.Arrays;
 import java.util.Collections;
+import java.util.List;
 
 import static org.hamcrest.Matchers.instanceOf;
 
@@ -96,6 +98,29 @@ public void testLegacyBestCompression() throws Exception {
         }
     }
 
+    public void testCodecRetrievalForUnknownCodec() throws Exception {
+        CodecService codecService = createCodecService();
+        IllegalArgumentException exception = assertThrows(IllegalArgumentException.class, () -> codecService.codec("unknown_codec"));
+        assertEquals("failed to find codec [unknown_codec]", exception.getMessage());
+    }
+
+    public void testAvailableCodecsContainsExpectedCodecs() throws Exception {
+        CodecService codecService = createCodecService();
+        String[] availableCodecs = codecService.availableCodecs();
+        List<String> codecList = Arrays.asList(availableCodecs);
+        int expectedCodecCount = Codec.availableCodecs().size() + 5;
+
+        assertTrue(codecList.contains(CodecService.DEFAULT_CODEC));
+        assertTrue(codecList.contains(CodecService.LEGACY_DEFAULT_CODEC));
+        assertTrue(codecList.contains(CodecService.BEST_COMPRESSION_CODEC));
+        assertTrue(codecList.contains(CodecService.LEGACY_BEST_COMPRESSION_CODEC));
+        assertTrue(codecList.contains(CodecService.LUCENE_DEFAULT_CODEC));
+
+        assertFalse(codecList.contains("unknown_codec"));
+
+        assertEquals(expectedCodecCount, availableCodecs.length);
+    }
+
     private CodecService createCodecService() throws IOException {
         Settings nodeSettings = Settings.builder().put(Environment.PATH_HOME_SETTING.getKey(), createTempDir()).build();
         IndexSettings settings = IndexSettingsModule.newIndexSettings("_na", nodeSettings);