Fix sneaky bug on iterator

carlosdelest · Dec 5, 2024 · 4c65c8a · 4c65c8a
1 parent ef8ac8c
commit 4c65c8a
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/...rc/main/java/org/elasticsearch/index/mapper/vectors/VectorSimilarityFloatValueSource.java b/...rc/main/java/org/elasticsearch/index/mapper/vectors/VectorSimilarityFloatValueSource.java
@@ -50,18 +50,14 @@ public DoubleValues getValues(LeafReaderContext ctx, DoubleValues scores) throws
         final KnnVectorValues.DocIndexIterator iterator = vectorValues.iterator();
 
         return new DoubleValues() {
-            private int docId = -1;
-
             @Override
             public double doubleValue() throws IOException {
                 vectorOpsCount++;
-                return vectorSimilarityFunction.compare(target, vectorValues.vectorValue(docId));
+                return vectorSimilarityFunction.compare(target, vectorValues.vectorValue(iterator.index()));
             }
 
             @Override
             public boolean advanceExact(int doc) throws IOException {
-                assert doc > iterator.docID();
-                docId = doc;
                 return doc >= iterator.docID() && iterator.docID() != DocIdSetIterator.NO_MORE_DOCS && iterator.advance(doc) == doc;
             }
         };