Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with JDK8 to allow using the library from java 8 projects #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rabelenda
Copy link

Additionally, upgrade jackson and set FAIL_ON_UNKNOWN_PROPERTIES property to false to avoid getting an exception when an unrecognized property is found in mpd (this is the expected behavior according to the iso, and reflected on schema).

@carlanton
Copy link
Owner

Hi Roger,

Thanks for the PR. Not sure if I want to go back to jdk 8. Why do you want to to this?

Also, you can already configure the objectmapper like this:

MPDParser parser = new MPDParser(MPDParser.defaultObjectMapper()
                .disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES));

@rabelenda
Copy link
Author

rabelenda commented Nov 21, 2019

Hi, thank you for your reply.

We want to use this great library from a JMeter plugin, and we don't want to add restrictions to users and enforce them to have to install newer jdks. If you don't want to support jdk8 then we would need to maintain a separate fork for this :-(.

Regarding modifying the object mapper from client code, do you think is better doing that from client side? I mean, it seems that the standard specifies that any "unknown" xml attribute or element should be ignored, so I would expect the library to do that by default.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants