Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added log agent" #1136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmholtz
Copy link

@dmholtz dmholtz commented Jan 15, 2025

This reverts commit 5828e59, which was breaking change given the pinned version of py-trees.

Checklist:

  • Your branch is up-to-date with the master branch and tested with latest changes
  • Extended the README / documentation, if necessary
  • Code compiles correctly and runs
  • Code is formatted and checked with Utilities/code_check_and_formatting.sh
  • Changelog is updated

Description

This PR simply reverts a breaking commit, which breaks scenario_runner.

Where has this been tested?

  • Platform(s): Ubuntu 22.04
  • Python version(s): 3.8 - 3.10
  • Unreal Engine version(s): 4.26
  • CARLA version: 0.9.15

Possible Drawbacks


This change is Reviewable

This reverts commit 5828e59.
@dmholtz
Copy link
Author

dmholtz commented Jan 16, 2025

After digging a bit deeper into this, I found that 5828e59 is indeed incompatible with this version of srunner, but consistent with the master branch of leaderboard. If compatibility with the latter is preferred, we may close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant