Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/event based form integration #251

Merged
merged 45 commits into from
Jan 6, 2025

Conversation

Sital999
Copy link
Collaborator

@Sital999 Sital999 commented Nov 6, 2024

  • Backend support for event-based integration on agent-node

@Sital999 Sital999 requested a review from mesudip November 6, 2024 05:09
@Sital999 Sital999 force-pushed the enhancement/event-based-form-integration branch from ae20e09 to 17f0b2b Compare December 6, 2024 10:07
@Sital999 Sital999 force-pushed the enhancement/event-based-form-integration branch from f62afa8 to 5c57ec2 Compare December 18, 2024 11:12
value: `${tx.hash.toString('hex')}#${index}`,
}))
: null
} catch (err) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log error with warning so that it can be debugged later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log added

let result
const matchedTxPath: any = []
try {
console.log(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

[],
matchedTxPath
)
console.log('tx=', tx.hash.toString('hex'), 'solution=', result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Copy link
Collaborator Author

@Sital999 Sital999 Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required to log the boolean of the filter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been replaced with console.debug

const eventBasedActions = formatEventFilter(
checkIfAgentWithEventTriggerTypeExists(configurations)
)
console.log('hello : ', eventBasedActions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -25,6 +25,29 @@ export function rewardAddressBech32(
)
}

export function convertToBufferIfBech32(address: any): Buffer | string| any {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used for conversion before comparision of value

_logicalFunctions.register('string','contains',(a:string,b:string)=> a.includes(b) || b.includes(a))

// Register handlers for buffers
_logicalFunctions.register('buffer', '==', (a: Buffer, b: Buffer) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not pretty

agent-node/src/utils/operatorSupport.ts Outdated Show resolved Hide resolved
@Sital999 Sital999 force-pushed the enhancement/event-based-form-integration branch from d97b702 to ebe865c Compare January 3, 2025 09:36
@Sital999 Sital999 merged commit 260cc08 into dev Jan 6, 2025
3 checks passed
@Sital999 Sital999 deleted the enhancement/event-based-form-integration branch January 6, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants