Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add email scope when requesting token #44

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

strieflin
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (7092006) to head (13f947d).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage     83.82%   83.82%           
  Complexity      400      400           
=========================================
  Files            69       69           
  Lines          1515     1515           
  Branches         81       81           
=========================================
  Hits           1270     1270           
  Misses          186      186           
  Partials         59       59           
Files with missing lines Coverage Δ
...n/java/io/carbynestack/cli/login/LoginCommand.java 87.80% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7092006...13f947d. Read the comment docs.

---- 🚨 Try these New Features:

@sbckr sbckr marked this pull request as ready for review November 19, 2024 11:40
@sbckr sbckr requested a review from a team as a code owner November 19, 2024 11:40
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit 702ba4c into master Nov 19, 2024
7 checks passed
@sbckr sbckr deleted the request-email-scope branch November 19, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issued ID Token does not contain email address
2 participants