Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ephemeral Execute with Tag option #18

Closed
wants to merge 1 commit into from
Closed

Added Ephemeral Execute with Tag option #18

wants to merge 1 commit into from

Conversation

grafjo
Copy link
Contributor

@grafjo grafjo commented Mar 15, 2022 •
edited
Loading

This was referenced Mar 15, 2022
Merged
Closed
@grafjo grafjo force-pushed the feature/upstream-select-secrets-by-tags branch from e48949b to 12c6349 Compare March 15, 2022 15:34
@kindlich @Lila84
Added Ephemeral Execute with Tag option
c972220 
Co-authored-by: Petra Scherer <[email protected]>
Co-authored-by: Timo Klenk <[email protected]>
Signed-off-by: Johannes Graf <[email protected]>
@grafjo grafjo force-pushed the feature/upstream-select-secrets-by-tags branch from 12c6349 to c972220 Compare April 21, 2022 10:00
@grafjo
Copy link
Contributor Author

grafjo commented Apr 21, 2022

@sbckr have rebased to current workflow files

sbckr
sbckr reviewed Apr 21, 2022
View reviewed changes
...ava/io/carbynestack/cli/client/ephemeral/command/ExecuteEphemeralClientCliCommandRunner.java
String code =
readCodeFromStdIn()
.getOrElseThrow(
e ->
new CsCliRunnerException(
getMessages().getString("execute.failure.read-code"), e));

Future<Either<ActivationError, List<ActivationResult>>> execute;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather call it execution, but that is a personal preference.

sbckr
sbckr reviewed Apr 21, 2022
View reviewed changes
src/test/java/io/carbynestack/cli/client/ephemeral/EphemeralClientCliTest.java
String uuid = UUID.randomUUID().toString();
String tagFilter = "key:value";

try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware that the existing tests for exceptions were all implemented with try/catch, but I would prefer the transition to Assert.assertThrows. Like

CsCliRunnerException actualCCRE = Assert.assertThrows(CsCliRunnerException.class, () ->
      getCliWithArgs(
              ExecuteEphemeralClientCliCommandConfig.COMMAND_NAME,
              "-i",
              uuid,
              "-f",
              tagFilter,
              "app.example.com")
          .parse());
    assertEquals(actualCCRE.getMessage(),
            EPHEMERAL_CLI_MESSAGES.getString("execute.failure.both-inputs-provided"));

sbckr
sbckr requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is missing dependency update for the Ephemeral java client (pom file) which requires carbynestack/ephemeral#17 to be merged

@sbckr
Copy link
Member

sbckr commented May 11, 2022

I have just realised, that the newly added option is not yet described in the readme`. (see README.md#usage).

So far we have inserted the respective help output at the corresponding place

@github-actions
Copy link

This PR has been marked stale because it has been open for 90 days with no activity. It will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2022
@strieflin strieflin added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 24, 2022
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2022
@strieflin strieflin added kind/feature Categorizes issue or PR as related to a new feature. triage/unresolved Indicates an issue that can not or will not be resolved. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 12, 2022
@strieflin
Copy link
Member

Needs to be addressed in a holistic way (see carbynestack/amphora#34).

@strieflin strieflin closed this Dec 12, 2022
@strieflin strieflin mentioned this pull request Dec 12, 2022
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbckr sbckr sbckr requested changes

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/unresolved Indicates an issue that can not or will not be resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grafjo @sbckr @strieflin @kindlich