Add a FacetValue instruction
#4545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
FacetValueinstruction representsC as Ifor some typeCand facet typeI. It is namedFacetValueinstead of justFacetto parallel theFacetTypeinstruction.This PR is limited by the fact that there is no current way to construct concrete facet values in the toolchain. These will be used in the future, though to support things like:
C as IwhereCis a class; andT:! Iparameter whereThas a concrete value.(Here
Iis an interface or other non-typefacet type.)Also do some renaming and add some comments to make things a bit more clear.
FacetTypeAccess->FacetAccessTypeto clarify this is not access of a facet type, but access of the type of a facet.facet_id->.facet_value_inst_idto parallel theFacetValueinstructionFacetAccessWitnesswill be in a future PR.