fix: add @emotion/is-prop-valid to dependency list to fix builds #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-youd
requested review from
davidmenendez and
anamikaanu96
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
DCO Assistant Lite bot All contributors have signed the DCO. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6673 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 397 397
Lines 12923 12923
Branches 4286 4286
=======================================
Hits 10427 10427
Misses 2496 2496
|
tom-youd
force-pushed
the
tom-youd-patch-1
branch
from
da4efe6 to
211f9a5
Compare
|
Thanks for helping out with all of the investigation you did here @tom-youd! This shouldn't be an issue now that we've rolled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6672
Added @emotion/is-prop-valid as a dependency to fix builds
What did you change?
As per above - added dependency to package.json (for Ibm-products)
How did you test and verify your work?
Building storybook locally