Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement useTagOverflow hook #6630

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

makafsal
Copy link
Member

Closes #6601

What did you change?

packages/ibm-products/src/components/TagOverflow/useTagOverflow.ts

How did you test and verify your work?

yarn test
yarn avt
Storybook

@makafsal makafsal requested a review from a team as a code owner December 24, 2024 11:25
@makafsal makafsal requested review from davidmenendez and amal-k-joy and removed request for a team December 24, 2024 11:25
Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 09a457e
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/676a9a10349fd700083a46ee
😎 Deploy Preview https://deploy-preview-6630--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 09a457e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/676a9a1044e2bf00080911d4
😎 Deploy Preview https://deploy-preview-6630--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.77%. Comparing base (03c31fc) to head (09a457e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6630   +/-   ##
=======================================
  Coverage   80.76%   80.77%           
=======================================
  Files         396      397    +1     
  Lines       12885    12889    +4     
  Branches     4267     4267           
=======================================
+ Hits        10407    10411    +4     
  Misses       2478     2478           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makafsal looks good!

I've also gone ahead and created a PR with my version of the refactor. There's a few changes I decided to make as part of the decoupling. Let's schedule some time next week to go over and discuss our changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move overflow functionality in TagOverflow to a separate file
2 participants