Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(createtearsheet): rename slug to decorator #6602

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sangeethababu9223
Copy link
Member

Closes #6456

Rename slug prop to decorator in CreateTearsheet

What did you change?

Updated the prop name slug in CreateTearsheet file and stories to decorator.
Added an extra option in controls to show non AILabel components being passed as decorator

How did you test and verify your work?

Storybook

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner December 18, 2024 06:59
@sangeethababu9223 sangeethababu9223 requested review from makafsal and matthewgallo and removed request for a team December 18, 2024 06:59
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 1e211a4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/676a359df03f5a0008c98ebd
😎 Deploy Preview https://deploy-preview-6602--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 1e211a4
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/676a359d670d520008ac3bd1
😎 Deploy Preview https://deploy-preview-6602--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (03c31fc) to head (1e211a4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6602      +/-   ##
==========================================
- Coverage   80.76%   80.63%   -0.14%     
==========================================
  Files         396      397       +1     
  Lines       12885    12910      +25     
  Branches     4267     4277      +10     
==========================================
+ Hits        10407    10410       +3     
- Misses       2478     2500      +22     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename slug prop to decorator in CreateTearsheet
2 participants