Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tearsheet): rename ailabel to decorator #6576

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sangeethababu9223
Copy link
Member

Closes #6455

Rename aiLabel prop to decorator in Tearsheet

What did you change?

Updated the prop name aiLabel in Tearsheet file and stories to decorator.
Added an extra option in controls to show non AILabel components being passed as decorator

How did you test and verify your work?

Storybook

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 63a9b34
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/676a35a347437300088740b5
😎 Deploy Preview https://deploy-preview-6576--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 63a9b34
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/676a35a347d6f70008242f90
😎 Deploy Preview https://deploy-preview-6576--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.77%. Comparing base (03c31fc) to head (63a9b34).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6576   +/-   ##
=======================================
  Coverage   80.76%   80.77%           
=======================================
  Files         396      396           
  Lines       12885    12887    +2     
  Branches     4267     4269    +2     
=======================================
+ Hits        10407    10409    +2     
  Misses       2478     2478           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@sangeethababu9223 sangeethababu9223 changed the title Chore(tearsheet): rename ailabel to decorator chore(tearsheet): rename ailabel to decorator Dec 12, 2024
@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review December 13, 2024 07:04
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner December 13, 2024 07:04
@sangeethababu9223 sangeethababu9223 requested review from devadula-nandan and amal-k-joy and removed request for a team December 13, 2024 07:04
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename aiLabel prop to decorator in Tearsheet
3 participants