chore(deps): update to react 19 #6552
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6552 +/- ##
==========================================
- Coverage 80.06% 79.53% -0.53%
==========================================
Files 394 394
Lines 12907 12893 -14
Branches 4277 4276 -1
==========================================
- Hits 10334 10255 -79
- Misses 2573 2638 +65
|
…ts into react-19-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6553
Adds support for React 19.
A side effect I found from the removal of prop types is the fact that none of the warnings/errors we emit from our custom prop validations are added anymore. This means that any test we previously had to ensure errors/warnings are logged now fail. As React is turning to TypeScript now for type checking, I've removed any tests that checked our old way with custom prop type validations.
Findings:
packages/core/.storybook/manager.js, rendering anything other than a string forsidebar.renderLabelfails.Issue withResolved with adding@carbon/reactTabscomponent, possibly because the version of@carbon/reactbeing used doesn't include React 19 support yet. If this is the case, we'll need to wait until a version supporting React 19 has been published.[email protected]to our resolutionsWhat did you change?
How did you test and verify your work?
Confirmed all tests pass, components in storybook render as expected