-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CoachmarkOverlayElements): Add next/back callbacks and currentStep properties #6548
feat(CoachmarkOverlayElements): Add next/back callbacks and currentStep properties #6548
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6548 +/- ##
==========================================
+ Coverage 79.91% 80.05% +0.13%
==========================================
Files 394 394
Lines 12888 12907 +19
Branches 4267 4277 +10
==========================================
+ Hits 10300 10333 +33
+ Misses 2588 2574 -14
|
@AlexanderMelox CI looks good. But I still cannot access the logs of |
I just got access to Percy so i can approve now |
Thanks @AlexanderMelox! |
@AlexanderMelox Following our suggestion and summarizing here ou exchange on slack:
However, testing the Anyway, this helped me fix a bug with the scroll position not being correct (the position of the carrousel was not correctly updated). |
@@ -248,6 +275,7 @@ export let CoachmarkOverlayElements = React.forwardRef< | |||
); | |||
scrollRef?.current?.scrollToView?.(targetStep); | |||
setCurrentProgStep(targetStep); | |||
onBack?.(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned on a slack DM, we will have the c4p team add this one in, its a bit more complicated
Jest doesn't really update css styles in testing so thats why it can be a little tricky to test scrolling and such, but we can handle it from now on |
36bd4f9
Closes #5596
This PR:
What did you change?
Add three optional properties to CoachmarkOverlayElements:
How did you test and verify your work?
I modified the story book as follows:
Then manually checked that: