test(ProductiveCard): add avt test coverage #6518
Conversation
devadula-nandan
requested review from
elycheea and
anamikaanu96
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6518 +/- ##
==========================================
- Coverage 79.97% 79.96% -0.01%
==========================================
Files 394 394
Lines 12894 12895 +1
Branches 4273 4274 +1
==========================================
Hits 10312 10312
- Misses 2582 2583 +1
|
| const buttons = page.locator(`button.${carbon.prefix}--btn`); | ||
| const disabledButton = buttons.nth(2); | ||
| expect(await disabledButton.getAttribute('disabled')).not.toBeNull(); |
There was a problem hiding this comment.
I think we typically try to query by role or text over a specific query selector.
In this case, we could probably do
const disabledButton = page.getByRole('button', { name: 'Read more' });Or some similar variation of that.
| const menuButton = page.locator('button[aria-haspopup="true"]'); | ||
| const menu = page.locator('ul[role="menu"]'); |
There was a problem hiding this comment.
We can probably use the roles here as well. :)
|
@elycheea fixed it |
elycheea
added
adopter: automation
im pretty sure we can deprecate although a more generic name any additional thoughts or suggestions? |
|
@anamikaanu96 done |
dd60a2e
Closes #6472
adds accessibility tests for productive card
Since we are in v12 OverflowMenu. i noticed that passing aria-label prop to v12 OverflowMenu spreads it to the overflow menu container which is a div and is reported as violation
v12 OverflowMenu uses single
Labelprop to set tooltip text on menu button and aria-label for list container (ul)which means we might need to deprecate either
iconDescriptionoroverflowAriaLabelasLabelprop handles both with v12 OverflowMenu.useful references
#5803
#6395
i have passed label as below, and awaiting for any review suggestions
What did you change?
e2e/components/ProductiveCard/ProductiveCard-test.avt.e2e.js
packages/ibm-products/src/components/Card/Card.tsx
How did you test and verify your work?
yarn avt